Skip to content

Conversation

@andrey18106
Copy link
Contributor

Add fallback to default /apps/ folder.
Related to: #618

@andrey18106
Copy link
Contributor Author

/backport to stable31

@kyteinsky
Copy link
Collaborator

From #618 (comment) and https://docs.nextcloud.com/server/latest/admin_manual/apps_management.html#using-custom-app-directories,
it seems like apps_path is always supposed to be an array but it wasn't in the linked issue so it was a config issue. That may have been fixed with just setting the writable key to true.
in the PR we might write to apps directory that are not supposed to be written. That should be an error as it was imo.

@andrey18106
Copy link
Contributor Author

From #618 (comment) and https://docs.nextcloud.com/server/latest/admin_manual/apps_management.html#using-custom-app-directories, it seems like apps_path is always supposed to be an array but it wasn't in the linked issue so it was a config issue. That may have been fixed with just setting the writable key to true. in the PR we might write to apps directory that are not supposed to be written. That should be an error as it was imo.

I agree, lets then keep it as it was, since it is supposed to work with apps_paths that is common recommended way of configuration.

@kyteinsky
Copy link
Collaborator

sorry I was mistaken with the apps_paths config key. It is an optional key and the fallback implemented here is correct: https://github.com/nextcloud/server/blob/083f0b51dd6740dc6973f9d3ec1f95719a1d7d0e/lib/base.php#L152-L164

@kyteinsky kyteinsky reopened this Sep 12, 2025
@kyteinsky
Copy link
Collaborator

/backport to stable32

Copy link
Contributor

@oleksandr-nc oleksandr-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyteinsky kyteinsky enabled auto-merge September 12, 2025 06:48
@kyteinsky kyteinsky merged commit 7ca8e25 into main Sep 12, 2025
35 checks passed
@kyteinsky kyteinsky deleted the fix/ex-app-archive-fetcher branch September 12, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants