fix(HaRP): do not block HaRP itself if requests contain a non-existent application #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t application Signed-off-by: Oleksander Piskun <[email protected]>
Contributor
Author
|
/backport to stable32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code can block HaRP itself very easy, just by sending requests like
curl http://nextlcoud.local/exapps/non-ex-appThis requests will hit HaRP and HaRP will call
getExAppMetadataendpoint which will ban it temporary.It is fine just to reply with 404 for such requests from AppAPI, and move auto-ban to the HaRP key failure validation attempts.
We should backport this to NC32.