Skip to content

Conversation

@lukasdotcom
Copy link
Member

@lukasdotcom lukasdotcom commented Jun 18, 2025

Resolves: #17
Resolves: #252

@lukasdotcom lukasdotcom force-pushed the feat/unapprove-when-modified branch 3 times, most recently from 81b45f3 to ae8c24b Compare June 18, 2025 18:14
@lukasdotcom lukasdotcom force-pushed the feat/unapprove-when-modified branch from ae8c24b to 0f67e38 Compare June 18, 2025 18:18
Signed-off-by: Lukas Schaefer <[email protected]>
@lukasdotcom lukasdotcom requested a review from julien-nc June 20, 2025 15:16
@lukasdotcom lukasdotcom force-pushed the feat/unapprove-when-modified branch from b622fc1 to c1405b6 Compare June 20, 2025 15:18
Signed-off-by: Lukas Schaefer <[email protected]>
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of nitpicking + some small mistakes.
But all good 👍

Signed-off-by: Lukas Schaefer <[email protected]>
@lukasdotcom lukasdotcom force-pushed the feat/unapprove-when-modified branch from a82561d to b03b62a Compare June 23, 2025 15:49
@lukasdotcom lukasdotcom requested a review from julien-nc June 23, 2025 15:50
@lukasdotcom lukasdotcom merged commit d5301aa into main Jun 24, 2025
39 checks passed
@lukasdotcom lukasdotcom deleted the feat/unapprove-when-modified branch June 24, 2025 00:49
@lukasdotcom lukasdotcom mentioned this pull request Jun 26, 2025
@thekk1
Copy link

thekk1 commented Jun 26, 2025

The migraion for the new column 'unapprove_when_modified' is for the Version 2.3.1.
Is this correct? I tried to test the current implementation and had to set the version manually in the appinfo/info.xml.

@lukasdotcom
Copy link
Member Author

The migraion for the new column 'unapprove_when_modified' is for the Version 2.3.1. Is this correct? I tried to test the current implementation and had to set the version manually in the appinfo/info.xml.

Hi @thekk1,

Even though the filename for the migration does say Version020301. It should still run when you update/install the app. You shouldn't need to set the app version to 2.3.1 in appinfo/info.xml.

@ER-EPR
Copy link

ER-EPR commented Aug 9, 2025

Even though the filename for the migration does say Version020301. It should still run when you update/install the app. You shouldn't need to set the app version to 2.3.1 in appinfo/info.xml.

But,I update today and any modification to the flow template failed, and result in a error in NC system log complaining about DB doesnt have column named unapprove_when_modified. Now I deleted all flow and cannot create them back.
@thekk1 Could you please tell me how to get it to work? Uninstall, modify appinfo/info.xml
to 2.3.1 and install back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove mark checked after document change Clean approval tag when a new version of file is uploaded

5 participants