-
Notifications
You must be signed in to change notification settings - Fork 8
feat: allow for removing file approval when file modified #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
81b45f3 to
ae8c24b
Compare
Signed-off-by: Lukas Schaefer <[email protected]>
ae8c24b to
0f67e38
Compare
Signed-off-by: Lukas Schaefer <[email protected]>
Signed-off-by: Lukas Schaefer <[email protected]>
b622fc1 to
c1405b6
Compare
Signed-off-by: Lukas Schaefer <[email protected]>
julien-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of nitpicking + some small mistakes.
But all good 👍
Signed-off-by: Lukas Schaefer <[email protected]>
a82561d to
b03b62a
Compare
|
The migraion for the new column 'unapprove_when_modified' is for the Version 2.3.1. |
Hi @thekk1, Even though the filename for the migration does say Version020301. It should still run when you update/install the app. You shouldn't need to set the app version to 2.3.1 in appinfo/info.xml. |
But,I update today and any modification to the flow template failed, and result in a error in NC system log complaining about DB doesnt have column named unapprove_when_modified. Now I deleted all flow and cannot create them back. |
Resolves: #17
Resolves: #252