Skip to content

Conversation

@lukasdotcom
Copy link
Member

Resolves: #44

@lukasdotcom lukasdotcom requested a review from julien-nc June 18, 2025 18:29
@julien-nc
Copy link
Member

I don't think having OCA\Approval\Attribute\RequireApprovalAdmin is needed. It is not checked by the server security middleware because there is no way the server is aware of this attribute.

You can check how it's done in the theming app (in the server repo).

  • Each controller method that is called by the settings section UI has the attribute #[AuthorizedAdminSetting(settings: Admin::class)] . The full class path is OCP\AppFramework\Http\Attribute\AuthorizedAdminSetting
  • NoAdminRequired must not be set

Signed-off-by: Lukas Schaefer <[email protected]>
@lukasdotcom
Copy link
Member Author

I used the group folders app as my example to build of, but didn't notice that there was a custom middleware in the app.

Signed-off-by: Lukas Schaefer <[email protected]>
@lukasdotcom lukasdotcom merged commit d064ade into main Jun 23, 2025
39 checks passed
@lukasdotcom lukasdotcom deleted the delegated-settings branch June 23, 2025 13:33
@thekk1
Copy link

thekk1 commented Jun 26, 2025

The implementation is not complete.
If I allow non admin persons or groups to setup the approval workflows, they are not able to see or set the invisible tags nor they are able to create some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement new admin delegation feature

4 participants