-
Notifications
You must be signed in to change notification settings - Fork 26
Support markdown links preview in chat UI #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
janepie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, looks good! Testing libraries left and right 🚀
|
Let's wait to merge that, I realized it was not avoiding the closing parenthesis. I think we need 2 regexps, one for plain URLs and one for markdown links. I'll do that later. |
|
Or we need to strip stuff from the end? Like if the link is part of a sentence in brackets (like this https://test.com) or at the end of a sentence with a dot e.g. https://test.com. |
|
The problem is that brackets are allowed in GET params. So why should we strip anything from (like that https://text.com?plop=lala) . |
f5a215e to
d3c4875
Compare
Signed-off-by: Julien Veyssier <[email protected]>
d3c4875 to
3d8a702
Compare
janepie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Override NcRichText link resolving to support markdown links.
This currently produces a lot of warnings because the
referencesprop of<NcRichText>is declared as Object but the implementation actually expects an array. I'll fix that in nc/vue.