feat(ChattyLLM): replace loading spinner with skeleton message #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
approved these changes
Apr 26, 2025
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Works just fine. Good that you removed the loading spinner in the submit button, it was a bit too much now with the placeholder message 👍
Signed-off-by: Edward Ly <[email protected]>
edward-ly
force-pushed
the
feat/chat-message-skeleton
branch
from
2a8c793 to
435bae6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #214. The LoadingPlaceholder component from the Talk app was copied and minimally adapted to fit the chat UI. Also, the message input field already displays
Processing...while the message is being generated, so I don't think there is a need for additional text underneath the placeholder either.