Skip to content

fix(settings): rename enable task checkbox labels, de-duplicate configured backends info #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edward-ly merged 2 commits into from
Jun 18, 2025
Merged

fix(settings): rename enable task checkbox labels, de-duplicate configured backends info #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00a6f37
fix(settings): rename enable task checkbox labels
edward-ly Jun 6, 2025
5561ec6
fix(settings): de-duplicate configured backends info
edward-ly Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/Settings/Personal.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,11 @@ public function getForm(): TemplateResponse {
$availableProviders = [];
foreach ($availableTaskTypes as $taskTypeId => $availableTaskType) {
try {
$provider = $this->taskProcessingManager->getPreferredProvider($taskTypeId);
$availableProviders[$availableTaskType['name']] = $provider->getName();
$providerName = $this->taskProcessingManager->getPreferredProvider($taskTypeId)->getName();
if (!isset($availableProviders[$providerName])) {
$availableProviders[$providerName] = [];
}
$availableProviders[$providerName][] = $availableTaskType['name'];
} catch (Exception $e) {
// pass
}
Expand Down
8 changes: 4 additions & 4 deletions src/components/AdminSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
:checked="state.assistant_enabled"
@update:checked="onCheckboxChanged($event, 'assistant_enabled')">
<div class="checkbox-text">
{{ t('assistant', 'Top-right assistant') }}
{{ t('assistant', 'Enable Nextcloud Assistant in header') }}
</div>
</NcCheckboxRadioSwitch>
<NcNoteCard v-if="!state.text_processing_available" type="info">
Expand All @@ -29,7 +29,7 @@
:disabled="!state.free_prompt_task_type_available"
@update:checked="onCheckboxChanged($event, 'free_prompt_picker_enabled')">
<div class="checkbox-text">
{{ t('assistant', 'AI text generation smart picker') }}
{{ t('assistant', 'Enable AI text generation in smart picker') }}
</div>
</NcCheckboxRadioSwitch>
<NcNoteCard v-if="!state.free_prompt_task_type_available" type="info">
Expand All @@ -48,7 +48,7 @@
:disabled="!state.text_to_image_picker_available"
@update:checked="onCheckboxChanged($event, 'text_to_image_picker_enabled')">
<div class="checkbox-text">
{{ t('assistant', 'Text-to-image smart picker') }}
{{ t('assistant', 'Enable text-to-image in smart picker') }}
</div>
</NcCheckboxRadioSwitch>
<NcNoteCard v-if="!state.text_to_image_picker_available" type="info">
Expand All @@ -67,7 +67,7 @@
:disabled="!state.speech_to_text_picker_available"
@update:checked="onCheckboxChanged($event, 'speech_to_text_picker_enabled')">
<div class="checkbox-text">
{{ t('assistant', 'Speech-to-text smart picker') }}
{{ t('assistant', 'Enable speech-to-text in smart picker') }}
</div>
</NcCheckboxRadioSwitch>
<NcNoteCard v-if="!state.speech_to_text_picker_available" type="info">
Expand Down
19 changes: 10 additions & 9 deletions src/components/PersonalSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,28 @@
:checked="state.assistant_enabled"
@update:checked="onCheckboxChanged($event, 'assistant_enabled')">
<div class="checkbox-text">
{{ t('assistant', 'Top-right assistant') }}
{{ t('assistant', 'Enable Nextcloud Assistant in header') }}
</div>
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch v-if="state.free_prompt_picker_available"
:checked="state.free_prompt_picker_enabled"
@update:checked="onCheckboxChanged($event, 'free_prompt_picker_enabled')">
<div class="checkbox-text">
{{ t('assistant', 'AI text generation smart picker') }}
{{ t('assistant', 'Enable AI text generation in smart picker') }}
</div>
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch v-if="state.text_to_image_picker_available"
:checked="state.text_to_image_picker_enabled"
@update:checked="onCheckboxChanged($event, 'text_to_image_picker_enabled')">
<div class="checkbox-text">
{{ t('assistant', 'AI image generation smart picker') }}
{{ t('assistant', 'Enable AI image generation in smart picker') }}
</div>
</NcCheckboxRadioSwitch>
<NcCheckboxRadioSwitch v-if="state.speech_to_text_picker_available"
:checked="state.speech_to_text_picker_enabled"
@update:checked="onCheckboxChanged($event, 'speech_to_text_picker_enabled')">
<div class="checkbox-text">
{{ t('assistant', 'AI transcription smart picker') }}
{{ t('assistant', 'Enable AI transcription in smart picker') }}
</div>
</NcCheckboxRadioSwitch>
<div v-if="noProvidersAvailable" class="settings-hint">
Expand All @@ -46,11 +46,12 @@
<div v-else>
<h3>{{ t('assistant', 'Configured backends') }}</h3>
<p>{{ t('assistant', 'The following services are used as backends for Nextcloud Assistant:') }}</p>
<ul>
<li v-for="(providerName, taskName) in providers" :key="taskName">
{{ t('assistant', '{providerName} for {taskName}', { providerName, taskName }, null, { escape: false }) }}
</li>
</ul>
<template v-for="(taskNames, providerName) in providers">
<h5 :key="providerName">
{{ providerName }}
</h5>
{{ taskNames.join(', ') }}
</template>
</div>
</div>
</div>
Expand Down
Loading