feat: show loading screen in task area only

[edward-ly]

Fixes #245. In addition, the task list is automatically updated when a new task is submitted or a running task is canceled, with the submitted task also being automatically selected from the list.

[julien-nc]

This looks great! A few things to adjust and we're good to go.

The task list item is not updated when the task finishes. Maybe we should fire an event in the event bus after pollTask so the TaskList component can update its internal task object status.
emit('task-updated', task)
which would be caught in TaskList and call a method like:

updateTask(task) {
    const internalTask = this.tasks.find(t => t.id === task.id)
    if (internalTask) {
        internalTask.status = task.status
    }
}

[edward-ly]

The task list item is not updated when the task finishes. Maybe we should fire an event in the event bus after pollTask so the TaskList component can update its internal task object status. emit('task-updated', task) which would be caught in TaskList and call a method like:

updateTask(task) {
    const internalTask = this.tasks.find(t => t.id === task.id)
    if (internalTask) {
        internalTask.status = task.status
    }
}

Is emit('task-updated', task) being called in assistant.js when the task finishes or somewhere else? How can the TaskList component listen to an emit from a grandparent?

Another alternative could be instead of declaring the tasks list in the TaskList component data, declare it in assistant.js instead and pass it down to TaskList as a component property.

[julien-nc]

Another alternative could be instead of declaring the tasks list in the TaskList component data, declare it in assistant.js instead and pass it down to TaskList as a component property.

It's a lot of chaining props to carry the value from assistant.js to TaskList. I would be in favor of using the event bus.

When using this function: import { emit } from '@nextcloud/event-bus' you can emit an event+data in the event bus.
You can subscribe to this event anywhere, this is independent from Vue.
In TaskList you can use import { subscribe } from '@nextcloud/event-bus' to subscribe to the event. You can do so in the mounted function:
subscribe('task-updated', this.updateTask)
and you need to unsubscribe when the TaskList component is destroyed, in the beforeDestroy block:
unsubscribe('task-updated', this.updateTask)

[edward-ly]

When using this function: import { emit } from '@nextcloud/event-bus' you can emit an event+data in the event bus. You can subscribe to this event anywhere, this is independent from Vue. In TaskList you can use import { subscribe } from '@nextcloud/event-bus' to subscribe to the event. You can do so in the mounted function: subscribe('task-updated', this.updateTask) and you need to unsubscribe when the TaskList component is destroyed, in the beforeDestroy block: unsubscribe('task-updated', this.updateTask)

done in 08c1af1, but using Object.assign(taskToUpdate, task) instead of taskToUpdate.status = task.status so that all task properties are updated

[julien-nc]

Works great. @janepie Could you give it a try as well?
@edward-ly Let's wait for Jana's feedback to merge this if you don't mind.

[janepie]

Nice one!
One thing: when I submit a task and then switch task type, I stay in the loading screen and cannot leave it in any way, even the buttons do not work anymore

[julien-nc]

@edward-ly You can rebase your branch on main where part of the task type switch issue was fixed (by #262).
The "task loading" state is still not reset correctly when switching task types.

[edward-ly]

Nice one! One thing: when I submit a task and then switch task type, I stay in the loading screen and cannot leave it in any way, even the buttons do not work anymore

Good catch, should be fixed in 12ecdad now, mind testing one last time? @janepie @julien-nc

[julien-nc]

The issue with switching task types while a task is "loading" is fixed when opening the assistant with the menu entry but not when opening it from a notification. See inline comment.

[janepie]

One more small thing: If I switch tasks or task types, I get a loading spinner on the Submit button and it doesn't disappear even if there is no task running

Do we still need this anywhere or is this a left-over from before?

[edward-ly]

One more small thing: If I switch tasks or task types, I get a loading spinner on the Submit button and it doesn't disappear even if there is no task running. Do we still need this anywhere or is this a left-over from before?

Not necessarily the red color, but I do see the button being in the wrong state too, latest commit should fix it.

@janepie feel free to merge this if everything looks good to you

[janepie]

I still have the loading spinner, I just made a recording

[edward-ly]

I still have the loading spinner, I just made a recording

Ah I see, I fixed the case for when a task from the task list is loaded, but not when switching task types or creating a new task, should be fixed now.

[janepie]

Looks good, really nice work!