UI adjustments #291
Merged
UI adjustments #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
julien-nc
commented
Jul 2, 2025
julien-nc
commented
- Fix issue when there is a 'output' output field that is not text (a check in a computed crashes)
- Nicer task list item display when there is only audio input or output
- Emphasize audio outputs with the same border as for text output
- Change how we record audio: convert to wav and then to mp3 to make sure it's small and compatible with many APIs/tools
- Vue 3 migration mistake: beforeDestroy is now beforeUnmount
- Fix style for "list of text" fields
- Fix item deletion for "list of text" fields
This was referenced Jul 2, 2025
Merged
kyteinsky
approved these changes
Jul 8, 2025
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/ui-adjustments
branch
from
1f6e0aa to
fd6004f
Compare
Member
Author
|
@kyteinsky Do you mean "Why don't we directly encode the recording to mp3 instead of using wav as intermediate format?" ? I didn't find reliable mp3 encoder that directly works with |
kyteinsky
reviewed
Jul 8, 2025
| async generateFile() { | ||
| this.killStreams() | ||
| if (!this.aborted) { | ||
| this.blob = new Blob(this.chunks, { type: 'audio/mp3' }) |
Contributor
There was a problem hiding this comment.
yeah that and if we were already doing mp3 before or was it not really mp3, just annotation?
Member
Author
There was a problem hiding this comment.
If we don't encode we don't know for sure what we get. On my side with Firefox I got OggVorbis.
Contributor
There was a problem hiding this comment.
ah okay that makes sense.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.