enh(audio-chat): add comments and adjust frontend error messages

Signed-off-by: Julien Veyssier <[email protected]>

lib/Controller/ChattyLLMController.php

@@ -230,6 +230,9 @@ private function deleteSessionTasks(string $userId, int $sessionId): void {
 					$task = $this->taskProcessingManager->getTask($ocpTaskId);
 					$this->taskProcessingManager->deleteTask($task);
 				} catch (\OCP\TaskProcessing\Exception\Exception) {
+					// silent failure here because:
+					// if the task is not found: all good nothing to delete
+					// if the task couldn't be deleted, it will be deleted by the task processing cleanup job later anyway
 				}
 			}
 		}

src/assistant.js

@@ -135,7 +135,10 @@ export async function openAssistantForm({
 								view.outputs = finishedTask?.output
 							}
 						} else if (finishedTask.status === TASK_STATUS_STRING.failed) {
-							showError(t('assistant', 'The server failed to process your task with ID {id}. Please inform the server administrators of this issue.', { id: finishedTask.id }))
+							showError(
+								t('assistant', 'The server failed to process your task with ID {id}', { id: finishedTask.id })
+									+ '. ' + t('assistant', 'Please inform the server administrators of this issue.'),
+							)
 							console.error('[assistant] Task failed', finishedTask)
 							view.outputs = null
 						}
@@ -210,7 +213,10 @@ export async function openAssistantForm({
 							view.outputs = finishedTask?.output
 							view.selectedTaskId = finishedTask?.id
 						} else if (finishedTask.status === TASK_STATUS_STRING.failed) {
-							showError(t('assistant', 'The server failed to process your task with ID {id}. Please inform the server administrators of this issue.', { id: finishedTask.id }))
+							showError(
+								t('assistant', 'The server failed to process your task with ID {id}', { id: finishedTask.id })
+									+ '. ' + t('assistant', 'Please inform the server administrators of this issue.'),
+							)
 							console.error('[assistant] Task failed', finishedTask)
 							view.outputs = null
 						}
@@ -497,7 +503,10 @@ export async function openAssistantTask(
 			.catch(error => {
 				view.unmount()
 				console.error('Assistant scheduling error', error)
-				showError(t('assistant', 'Assistant failed to schedule your task. Please try again and inform the server administrators if this issue persists.'))
+				showError(
+					t('assistant', 'Assistant failed to schedule your task')
+						+ '. ' + t('assistant', 'Please try again and inform the server administrators if this issue persists.'),
+				)
 			})
 	})
 	const syncSubmit = (inputs, taskTypeId, newTaskCustomId = '') => {
@@ -518,7 +527,10 @@ export async function openAssistantTask(
 					if (finishedTask.status === TASK_STATUS_STRING.successful) {
 						view.outputs = finishedTask?.output
 					} else if (finishedTask.status === TASK_STATUS_STRING.failed) {
-						showError(t('assistant', 'The server failed to process your task with ID {id}. Please inform the server administrators of this issue.', { id: finishedTask.id }))
+						showError(
+							t('assistant', 'The server failed to process your task with ID {id}', { id: finishedTask.id })
+								+ '. ' + t('assistant', 'Please inform the server administrators of this issue.'),
+						)
 						console.error('[assistant] Task failed', finishedTask)
 						view.outputs = null
 					}
@@ -591,7 +603,10 @@ export async function openAssistantTask(
 						view.outputs = finishedTask?.output
 						view.selectedTaskId = finishedTask?.id
 					} else if (finishedTask.status === TASK_STATUS_STRING.failed) {
-						showError(t('assistant', 'The server failed to process your task with ID {id}. Please inform the server administrators of this issue.', { id: finishedTask.id }))
+						showError(
+							t('assistant', 'The server failed to process your task with ID {id}', { id: finishedTask.id })
+								+ '. ' + t('assistant', 'Please inform the server administrators of this issue.'),
+						)
 						console.error('[assistant] Task failed', finishedTask)
 						view.outputs = null
 					}

src/components/ChattyLLM/InputArea.vue

@@ -132,7 +132,10 @@ export default {
 			axios.post(url, formData).then(response => {
 				this.$emit('submit-audio', response.data.ocs.data.fileId)
 			}).catch(error => {
-				showError(t('assistant', 'Could not upload the recorded file'))
+				showError(
+					t('assistant', 'Could not upload the recorded file')
+						+ '. ' + t('assistant', 'Please try again and inform the server administrators if this issue persists.'),
+				)
 				console.error(error)
 			})
 		},

src/components/fields/AudioRecorderWrapper.vue

@@ -140,9 +140,9 @@ export default {
 				console.debug(exception)
 				this.killStreams()
 				if (exception.name === 'NotAllowedError') {
-					showError(t('assistant', 'Access to the microphone was denied'))
+					showError(t('assistant', 'Access to the microphone was denied. Please check you allowed this page to access the microphone.'))
 				} else {
-					showError(t('assistant', 'Microphone either not available or disabled in settings'))
+					showError(t('assistant', 'Microphone either not available or disabled in settings. Check you are accessing this page with HTTPS or adjust your browser settings.'))
 				}
 				return
 			}
@@ -154,7 +154,10 @@ export default {
 				console.debug(exception)
 				this.killStreams()
 				this.audioStream = null
-				showError(t('assistant', 'Error while recording audio'))
+				showError(
+					t('assistant', 'Error while recording audio')
+						+ '. ' + t('assistant', 'Please try again and inform the server administrators if this issue persists.'),
+				)
 				return
 			}