Skip to content

Fix: chat user instruction handling #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julien-nc merged 2 commits into from
Jul 8, 2025
Merged

Fix: chat user instruction handling #297

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
522bdfc
fix: chat title generation
janepie Jul 8, 2025
7e8bae0
fix: chat user instructions
janepie Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: chat title generation 
Signed-off-by: Jana Peper <[email protected]>
  • Loading branch information
@janepie
janepie committed Jul 8, 2025
commit 522bdfcc119340e8e2f168f42e8df146dec54d61
4 changes: 2 additions & 2 deletions lib/Controller/ChattyLLMController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ public function generateTitle(int $sessionId): JSONResponse {
Application::APP_ID,
'chat_user_instructions_title',
Application::CHAT_USER_INSTRUCTIONS_TITLE,
);
) ?: Application::CHAT_USER_INSTRUCTIONS_TITLE;
$userInstructions = str_replace('{user}', $user->getDisplayName(), $userInstructions);

$systemPrompt = '';
Expand Down Expand Up @@ -733,7 +733,7 @@ public function checkTitleGenerationTask(int $taskId, int $sessionId): JSONRespo
Application::APP_ID,
'chat_user_instructions_title',
Application::CHAT_USER_INSTRUCTIONS_TITLE,
);
) ?: Application::CHAT_USER_INSTRUCTIONS_TITLE;
$userInstructions = str_replace('{user}', $user->getDisplayName(), $userInstructions);
$title = str_replace($userInstructions, '', $taskOutput);
$title = str_replace('"', '', $title);
Expand Down