Skip to content

Only show the group file action if necessary #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julien-nc merged 1 commit into from
Aug 25, 2025
Merged

Only show the group file action if necessary #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(file-actions): only show the group file action if necessary 
Signed-off-by: Julien Veyssier <[email protected]>
  • Loading branch information
@julien-nc
julien-nc committed Aug 25, 2025
commit 12f237a5ca265b2a919baa5cf9ee321af35c444a
13 changes: 10 additions & 3 deletions src/files/fileActions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const actionIgnoreLists = [
'files.public',
]

function registerGroupAction() {
function registerGroupAction(mimeTypes) {
const groupAction = new FileAction({
id: 'assistant-group',
displayName: (nodes) => {
Expand All @@ -28,7 +28,7 @@ function registerGroupAction() {
&& nodes.length === 1
&& !nodes.some(({ permissions }) => (permissions & Permission.READ) === 0)
&& nodes.every(({ type }) => type === FileType.File)
// && nodes.every(({ mime }) => ['text/plain', 'text/markdown'].includes(mime))
&& nodes.every(({ mime }) => mimeTypes.includes(mime))
},
iconSvgInline: () => CreationSvgIcon,
order: 0,
Expand Down Expand Up @@ -163,7 +163,14 @@ const ttsAvailable = loadState('assistant', 'tts-available', false)

if (assistantEnabled) {
if (summarizeAvailable || sttAvailable || ttsAvailable) {
registerGroupAction()
const groupMimeTypes = []
if (summarizeAvailable || ttsAvailable) {
groupMimeTypes.push(...VALID_TEXT_MIME_TYPES)
}
if (sttAvailable) {
groupMimeTypes.push(...VALID_AUDIO_MIME_TYPES)
}
registerGroupAction(groupMimeTypes)
}
if (sttAvailable) {
registerSttAction()
Expand Down
Loading