Skip to content

fix: scope of conflict variable #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Feb 3, 2023
Merged

fix: scope of conflict variable #366

ChristophWurst merged 1 commit into from
Feb 3, 2023

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Feb 3, 2023 •
edited
Loading

This should fix failing backports.

Logged error message

ERROR probot: Backport to stable5.0 failed
ERROR probot: conflicts is not defined
  ReferenceError: conflicts is not defined
      at module.exports (/app/lib/git.js:74:5)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:93:5)
      at async module.exports (/app/lib/backport.js:78:45)
      at async Command.callback (/app/index.js:50:21)

@st3iny
fix: scope of conflict variable
d186b96 
This should fix failing backports.

Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny added the bug Something isn't working label Feb 3, 2023
@st3iny st3iny self-assigned this Feb 3, 2023
ChristophWurst
ChristophWurst approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#fail

@ChristophWurst
Copy link
Member

ChristophWurst commented Feb 3, 2023

caused by 248c5b1

@ChristophWurst ChristophWurst merged commit d5f64ee into master Feb 3, 2023
@ChristophWurst ChristophWurst deleted the fix/noid/failing-backport branch February 3, 2023 14:26
This was referenced Feb 3, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@st3iny st3iny

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@st3iny @ChristophWurst