-
-
Notifications
You must be signed in to change notification settings - Fork 179
Implement unified search provider #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement unified search provider #1137
Conversation
Inner filtering can be done on the top right search design, like Talk. But regarding bookmarks, I'm wondering if this shouldn't be done with Unified search only, no? |
| .breadcrumbs { | ||
| padding: 0 8px 0 44px; | ||
| display: flex; | ||
| position: absolute; | ||
| z-index: 100; | ||
| background: var(--color-main-background-translucent); | ||
| left: 0; | ||
| right: 0; | ||
| top: 0; | ||
| padding: 0 8px 0 44px; | ||
| display: flex; | ||
| position: absolute; | ||
| z-index: 100; | ||
| background: var(--color-main-background-translucent); | ||
| left: 0; | ||
| right: 0; | ||
| top: 0; | ||
| } | ||
| .breadcrumbs + * { | ||
| margin-top: 50px; | ||
| margin-top: 50px; | ||
| } | ||
| .breadcrumbs__path { | ||
| display: flex; | ||
| align-items: center; | ||
| flex: 0; | ||
| display: flex; | ||
| align-items: center; | ||
| flex: 0; | ||
| } | ||
| .breadcrumbs__path > * { | ||
| display: inline-block; | ||
| height: 30px; | ||
| padding: 5px 7px; | ||
| flex-shrink: 0; | ||
| display: inline-block; | ||
| height: 30px; | ||
| padding: 5px 7px; | ||
| flex-shrink: 0; | ||
| } | ||
| .breadcrumbs__path > *:not(.icon-breadcrumb) { | ||
| min-width: 30px; | ||
| opacity: 0.7; | ||
| min-width: 30px; | ||
| opacity: 0.7; | ||
| } | ||
| .breadcrumbs__path > *:hover { | ||
| opacity: 1; | ||
| opacity: 1; | ||
| } | ||
| .breadcrumbs__tags { | ||
| width: 300px; | ||
| flex: 1; | ||
| width: 300px; | ||
| flex: 1; | ||
| } | ||
| .breadcrumbs__tags .multiselect__tags { | ||
| border-top: none !important; | ||
| border-left: none !important; | ||
| border-right: none !important; | ||
| border-top: none !important; | ||
| border-left: none !important; | ||
| border-right: none !important; | ||
| } | ||
| .breadcrumbs__AddFolder { | ||
| margin-left: 5px; | ||
| padding: 0; | ||
| margin-top: -10px; | ||
| margin-left: 5px; | ||
| padding: 0; | ||
| margin-top: -10px; | ||
| } | ||
| .breadcrumbs__controls { | ||
| flex: 2; | ||
| display: flex; | ||
| flex-direction: row-reverse; | ||
| padding: 0; | ||
| flex: 2; | ||
| display: flex; | ||
| flex-direction: row-reverse; | ||
| padding: 0; | ||
| } | ||
| .breadcrumbs__controls > * { | ||
| min-width: 30px; | ||
| min-width: 30px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabs? :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, github only displayed your comments only after I merged. Ah will fix those tabs.
True, but I want to support older nextcloud versions as well, so moving the search into the control bar is a good solution, yeah. |
You can still use the old search with a simple class check to see if the UnifiedSearch is enabled and active 🤷 That would keep it simple and avoid you using your own input? |
|
Ah, nice idea.Thanks :) |
see nextcloud/server#21971