fix service worker #1889
Merged
fix service worker #1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1889 +/- ##
=========================================
Coverage 43.97% 43.97%
Complexity 1453 1453
=========================================
Files 98 98
Lines 5706 5706
=========================================
Hits 2509 2509
Misses 3197 3197 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
szaimen
commented
Sep 3, 2022
Signed-off-by: szaimen <[email protected]>
szaimen
force-pushed
the
fix/1078/service-worker
branch
from
ca29d0a to
145a103
Compare
Contributor
Author
|
ping @marcelklehr |
Signed-off-by: Marcel Klehr <[email protected]>
szaimen
commented
Sep 13, 2022
This reverts commit 3afc5f7. Signed-off-by: szaimen <[email protected]>
Signed-off-by: szaimen <[email protected]>
Contributor
Author
|
@marcelklehr I think this should work now. However not really sure how to test since my test instance uses a self-signed certificate which makes service-workers unsupported by definition. |
szaimen
commented
Sep 26, 2022
marcelklehr
approved these changes
Sep 26, 2022
Member
|
Tested and can confirm it works! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via https://github.com/search?q=org%3Anextcloud+noRewrite&type=code
Close #1078
Disclaimer: I wasn't able to test this but I think it should work.
Signed-off-by: szaimen [email protected]