Replace ColorIndicator with Checkbox #1616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Georg Ehrke <[email protected]>
georgehrke
force-pushed
the
feature/noid/replace_color_with_checkbox
branch
from
9cbbcb2 to
07df146
Compare
Member
Author
|
Current version: I'm not really happy how it looks with bright colors like the birthday calendar though. |
Member
Either blacklist these colors (related to nextcloud/server#17148) or try to color the check black when color is bright. Otherwise it looks pretty good! |
Member
|
The icon was replaced in #3960. This PR is likely obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Georg Ehrke [email protected]