Skip to content

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented May 31, 2021

@GretaD GretaD self-assigned this May 31, 2021
@GretaD GretaD added the 2. developing Work in progress label May 31, 2021
@GretaD GretaD requested a review from ChristophWurst May 31, 2021 19:34
@ChristophWurst ChristophWurst marked this pull request as draft May 31, 2021 19:35
@ChristophWurst ChristophWurst self-assigned this May 31, 2021
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #3129 (7a3e584) into master (b46e217) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 7a3e584 differs from pull request most recent head 1a8ccdc. Consider uploading reports for the commit 1a8ccdc to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3129      +/-   ##
============================================
- Coverage     28.91%   28.86%   -0.06%     
  Complexity      121      121              
============================================
  Files           157      157              
  Lines          5717     5727      +10     
  Branches        839      840       +1     
============================================
  Hits           1653     1653              
- Misses         4064     4074      +10     
Flag Coverage Δ
javascript 23.39% <0.00%> (-0.05%) ⬇️
php 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/AppNavigation/CalendarList/Trashbin.vue 0.00% <0.00%> (ø)
src/store/calendars.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46e217...1a8ccdc. Read the comment docs.

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews enhancement New feature request and removed 2. developing Work in progress labels Jun 2, 2021
@ChristophWurst ChristophWurst marked this pull request as ready for review June 2, 2021 08:08
@ChristophWurst ChristophWurst added this to the v2.3.0 milestone Jun 2, 2021
@ChristophWurst ChristophWurst force-pushed the add/delete-button-trashbin branch from 7a3e584 to 1d16037 Compare June 2, 2021 09:38
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works :)

@ChristophWurst ChristophWurst force-pushed the add/delete-button-trashbin branch from 1d16037 to 1a8ccdc Compare June 4, 2021 07:54
@ChristophWurst ChristophWurst merged commit 7cfee1c into master Jun 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the add/delete-button-trashbin branch June 4, 2021 08:08
@ChristophWurst ChristophWurst added the Feature: Trash bin Deleted calendars, events and other objects in the caldav trash bin UI label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature request Feature: Trash bin Deleted calendars, events and other objects in the caldav trash bin UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Trashbin" vs "Trash bin" Allow users to delete trash bin elements permanently

3 participants