Bump deps / @nextcloud/webpack-vue-config and use npm7

[skjnldsv]

ref nextcloud/app-tutorial#319

• Feel free to revert all my github actions changes
• There is ONE linting issue that require a bit more attention
• Builds fine BUT didn't look extensively at the ui (seems good at first sight)

[codecov]

Codecov Report

Merging #3215 (578e97d) into master (1b9535d) will decrease coverage by 0.59%.
The diff coverage is 0.00%.

❗ Current head 578e97d differs from pull request most recent head 3c98f7a. Consider uploading reports for the commit 3c98f7a to get more accurate results

@@             Coverage Diff              @@
##             master    #3215      +/-   ##
============================================
- Coverage     28.89%   28.30%   -0.60%     
  Complexity      122      122              
============================================
  Files           158      157       -1     
  Lines          5741     5854     +113     
  Branches        844      811      -33     
============================================
- Hits           1659     1657       -2     
- Misses         4082     4197     +115     

Flag	Coverage Δ
javascript	22.87% <0.00%> (-0.53%)	⬇️
php	94.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...NavigationHeader/AppNavigationHeaderDatePicker.vue	0.00% <0.00%> (ø)
src/components/AppNavigation/CalendarList.vue	0.00% <ø> (ø)
...ts/AppNavigation/CalendarList/CalendarListItem.vue	0.00% <0.00%> (ø)
...nts/AppNavigation/CalendarList/CalendarListNew.vue	0.00% <0.00%> (ø)
...Navigation/CalendarList/PublicCalendarListItem.vue	0.00% <0.00%> (ø)
...components/AppNavigation/CalendarList/Trashbin.vue	0.00% <ø> (ø)
src/components/AppNavigation/Settings.vue	0.00% <0.00%> (ø)
...ponents/AppNavigation/Settings/ImportScreenRow.vue	0.00% <ø> (ø)
src/components/CalendarGrid.vue	0.00% <ø> (ø)
...rc/components/Editor/Alarm/AlarmTimeUnitSelect.vue	0.00% <ø> (ø)
... and 38 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9535d...3c98f7a. Read the comment docs.

[st3iny]

I just tested a bit and the UI seems to work fine.

I have no idea what the linter is trying to tell us:

/var/www/nextcloud/dev_apps/calendar/src/components/AppNavigation/Settings/ImportScreenRow.vue
  71:20  error  Unexpected side effect in "calendars" computed property  vue/no-side-effects-in-computed-properties

I don't see a side effect in the mentioned computed property 🤷‍♂️

[skjnldsv]

I don't see a side effect in the mentioned computed property

Arrays are passed as references, pushing an item into it will update the orignal store value

[st3iny]

I don't see a side effect in the mentioned computed property

Arrays are passed as references, pushing an item into it will update the orignal store value

Sure but the linter complains even if I remove the push or slice the array right after obtaining it from the getter.

[skjnldsv]

Sure but the linter complains even if I remove the push or slice the array right after obtaining it from the getter.

Indeed

[st3iny]

I resolved all conflicts, rebased and fixed all pending issues. Let's get this merged quickly before more conflicts arise and I have to start over again.

@ChristophWurst The required checks have to be adjusted in the repository settings. I renamed the build jobs for consistency with the js tests jobs.

[ChristophWurst]

👍 but didn' test

[st3iny]

I did some extensive testing and didn't encounter a broken feature.