Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Nov 2, 2021

Fix #3483

Modal

Screenshot 2021-11-05 at 14-58-31 November 2021 - Kalender - Nextcloud

Warning in sidebar if no email is configured

Screenshot 2021-11-05 at 12-36-12 November 2021 - Kalender - Nextcloud

TODO

  • Implement service
  • Implement availability inputs (reuse code from settings) Add scheduling availability settings server#27466
  • Localization
  • Fix the visibility input (I confused it with time transparency) => Should be PUBLIC, PRIVATE, etc.
  • Initial state for configs OR fetch them after the page load via a GET
  • Implement delete button (store action already present)
  • Fix config list reactivity (works if there is initial state; doesn't work if not)
  • Show warning when no email is configured

@st3iny st3iny added this to the v2.4.0 milestone Nov 2, 2021
@st3iny st3iny self-assigned this Nov 2, 2021
@ChristophWurst ChristophWurst changed the base branch from master to enhancement/appointments November 2, 2021 12:38
@st3iny st3iny force-pushed the enh/3483/appointment-crud-ui branch from 59f3375 to 177a599 Compare November 2, 2021 16:57
@ChristophWurst ChristophWurst force-pushed the enh/3483/appointment-crud-ui branch from 177a599 to 8104be1 Compare November 2, 2021 17:23
@ChristophWurst
Copy link
Member

Rebased to pull in the REST API and clean up the slightly off track history

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #3590 (1dc10d4) into enhancement/appointments (73215d2) will decrease coverage by 0.80%.
The diff coverage is 0.89%.

❗ Current head 1dc10d4 differs from pull request most recent head 1ae4b38. Consider uploading reports for the commit 1ae4b38 to get more accurate results
Impacted file tree graph

@@                     Coverage Diff                      @@
##           enhancement/appointments    #3590      +/-   ##
============================================================
- Coverage                     22.14%   21.34%   -0.81%     
============================================================
  Files                           163      179      +16     
  Lines                          5621     5842     +221     
  Branches                        874      891      +17     
============================================================
+ Hits                           1245     1247       +2     
- Misses                         4376     4595     +219     
Flag Coverage Δ
javascript 21.34% <0.89%> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/AppNavigation/AppointmentConfigList.vue 0.00% <0.00%> (ø)
...ppointmentConfigList/AppointmentConfigListItem.vue 0.00% <0.00%> (ø)
src/components/AppointmentConfigModal.vue 0.00% <0.00%> (ø)
...s/AppointmentConfigModal/CheckedDurationSelect.vue 0.00% <0.00%> (ø)
...omponents/AppointmentConfigModal/DurationInput.vue 0.00% <0.00%> (ø)
...mponents/AppointmentConfigModal/DurationSelect.vue 0.00% <0.00%> (ø)
...s/AppointmentConfigModal/NoEmailAddressWarning.vue 0.00% <0.00%> (ø)
.../components/AppointmentConfigModal/NumberInput.vue 0.00% <0.00%> (ø)
src/components/AppointmentConfigModal/Select.vue 0.00% <0.00%> (ø)
src/components/AppointmentConfigModal/TextArea.vue 0.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73215d2...1ae4b38. Read the comment docs.

@ChristophWurst ChristophWurst force-pushed the enh/3483/appointment-crud-ui branch from 8104be1 to 9af4978 Compare November 3, 2021 09:34
@st3iny

This comment has been minimized.

@GretaD GretaD force-pushed the enh/3483/appointment-crud-ui branch from 865b142 to 01928ba Compare November 3, 2021 11:21
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works :shipit:

@ChristophWurst ChristophWurst marked this pull request as ready for review November 5, 2021 14:15
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 5, 2021
@st3iny st3iny force-pushed the enh/3483/appointment-crud-ui branch from 1dc10d4 to 1ae4b38 Compare November 5, 2021 14:59
@st3iny st3iny merged commit 3b1a6fb into enhancement/appointments Nov 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the enh/3483/appointment-crud-ui branch November 5, 2021 15:09
@ChristophWurst ChristophWurst modified the milestones: v2.4.0, v3.0.0 Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRUD UI for appointment configurations

3 participants