Skip to content

[stable3.0] Fix: Inconsistencies due to ALTREP parameter #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
st3iny merged 2 commits into from
Jan 28, 2022
Merged

[stable3.0] Fix: Inconsistencies due to ALTREP parameter #3920

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6df7166
remove altrep parameter upon description update
max65482 Jan 27, 2022
88645fd
move fix to method changeDescription
max65482 Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
move fix to method changeDescription 
Signed-off-by: Maximilian Martin <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
  • Loading branch information
@max65482 @st3iny
max65482 authored and st3iny committed Jan 28, 2022
commit 88645fdd09384c994b717d7c733a73cab1520601
20 changes: 8 additions & 12 deletions src/store/calendarObjectInstance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,14 @@ const mutations = {
* @param {string} data.description New description to set
*/
changeDescription(state, { calendarObjectInstance, description }) {
// ALTREP parameter is not set by NC calendar, but by CalDAV clients like Thunderbird.
// To avoid inconsistencies, remove ALTREP parameter upon modification.
const descriptionProperty = calendarObjectInstance.eventComponent.getFirstProperty('Description')
if (descriptionProperty) {
if (descriptionProperty.hasParameter('ALTREP')) {
descriptionProperty.deleteParameter('ALTREP')
}
}
calendarObjectInstance.eventComponent.description = description
calendarObjectInstance.description = description
},
Expand Down Expand Up @@ -1518,18 +1526,6 @@ const actions = {
const calendarObject = state.calendarObject

if (eventComponent.isDirty()) {
// ALTREP parameter is not set by NC calendar, but by CalDAV clients like Thunderbird.
// To avoid inconsistencies, remove ALTREP parameter upon modification.
const veventComponent = calendarObject.calendarComponent.getFirstComponent('VEVENT')
if (veventComponent) {
const descriptionProperty = veventComponent.getFirstProperty('Description')
if (descriptionProperty) {
if (descriptionProperty.hasParameter('ALTREP')) {
descriptionProperty.deleteParameter('ALTREP')
}
}
}

const isForkedItem = eventComponent.primaryItem !== null
let original = null
let fork = null
Expand Down