Compare lower case email when checking invitees #4198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When comparing email to check if it is present in the invitees list, we do not normalize the value. This leads to inconsistancies: - the user will see two options when searching for [email protected] if the stored email is [email protected] - the user will see one option when searching for [email protected] if the stored email is [email protected] This PR transform the values to lower cases to consolidate the number of options offered to the user. Signed-off-by: Louis Chemineau <[email protected]>
artonge
added
3. to review
Codecov Report
@@ Coverage Diff @@
## main #4198 +/- ##
=========================================
Coverage 29.72% 29.72%
Complexity 330 330
=========================================
Files 220 220
Lines 7611 7611
Branches 1004 1004
=========================================
Hits 2262 2262
Misses 5349 5349
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tcitworld
approved these changes
May 5, 2022
tcitworld
requested review from
a team,
ChristophWurst and
st3iny
and removed request for
a team
Member
|
Is this a feature or a fix? Backport to the v3.3 line? |
Contributor
Author
|
Fix, yes backport could be nice. |
Contributor
Author
|
/backport to stable3.3 |
backportbot-nextcloud
bot
added
the
backport-request
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing email to check if it is present in the invitees list, we do not normalize the value.
This leads to inconsistencies:
This PR transform the values to lower cases to consolidate the number of options offered to the user.