Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 30, 2023

https://www.rfc-editor.org/rfc/rfc4791#section-5.2.2

Description: The CALDAV:calendar-timezone property is used to
specify the time zone the server should rely on to resolve "date"
values and "date with local time" values (i.e., floating time) to
"date with UTC time" values. The server will require this
information to determine if a calendar component scheduled with
"date" values or "date with local time" values overlaps a CALDAV:
time-range specified in a CALDAV:calendar-query REPORT. The
server will also require this information to compute the proper
FREEBUSY time period as "date with UTC time" in the VFREEBUSY
component returned in a response to a CALDAV:free-busy-query
REPORT request that takes into account calendar components
scheduled with "date" values or "date with local time" values. In
the absence of this property, the server MAY rely on the time zone
of their choice.

Ref #4778 (comment)

Todo

  • Make it work
  • Make it pretty

Bildschirmfoto vom 2023-01-30 20-13-27

@ChristophWurst ChristophWurst added 2. developing Work in progress enhancement New feature request feature: caldav labels Jan 30, 2023
@ChristophWurst ChristophWurst self-assigned this Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

❌ Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.15%. Comparing base (2692d49) to head (c96dfe9).
⚠️ Report is 2355 commits behind head on main.

Files with missing lines Patch % Lines
src/components/AppNavigation/EditCalendarModal.vue 0.00% 28 Missing ⚠️
src/store/calendars.js 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4935      +/-   ##
============================================
- Coverage     22.25%   22.15%   -0.10%     
  Complexity      334      334              
============================================
  Files           227      227              
  Lines         10789    10837      +48     
  Branches       2045     2054       +9     
============================================
  Hits           2401     2401              
- Misses         8388     8436      +48     
Flag Coverage Δ
javascript 14.15% <0.00%> (-0.08%) ⬇️
php 64.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

const jCal = ICAL.parse(this.calendar.timezone)
const iCalComp = new ICAL.Component(jCal)
const tzComp = TimezoneComponent.fromICALJs(iCalComp)
this.calendarTimezone = tzComp.getFirstComponent('VTIMEZONE').getFirstProperty('TZID').value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (non-blocking): Do we need to validate the value? Maybe use calendar-js' TimezoneManager.hasTimezoneForId() before assigning it?

@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress labels May 23, 2025
@SebastianKrupinski
Copy link
Contributor

Closing as this is no longer relavent

@ChristophWurst ChristophWurst deleted the feat/caldav/calendar-timezone-picker branch September 5, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1. to develop Accepted and waiting to be taken care of enhancement New feature request feature: caldav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants