fix: Warning: Undefined variable $mailService #7358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
requested review from
st3iny and
tcitworld
as code owners
Contributor
Author
|
/backport to stable6.0 |
backportbot
bot
added
the
backport-request
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7358 +/- ##
=======================================
Coverage 13.68% 13.68%
=======================================
Files 218 218
Lines 11174 11174
Branches 2684 2684
=======================================
Hits 1529 1529
Misses 9295 9295
Partials 350 350
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
st3iny
approved these changes
Sep 5, 2025
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
ErrorException: Warning: Undefined variable $mailService
#0 /calendar/lib/Service/Proposal/ProposalService.php(515): OCA\Calendar\Service\Proposal\ProposalService::sendEmailNotifications
#1 /calendar/lib/Service/Proposal/ProposalService.php(426): OCA\Calendar\Service\Proposal\ProposalService::generateNotifications
#2 /calendar/lib/Service/Proposal/ProposalService.php(258): OCA\Calendar\Service\Proposal\ProposalService::modifyProposal
#3 /calendar/lib/Controller/ProposalController.php(148): OCA\Calendar\Controller\ProposalController::modify