Allow to set headers for dav objects #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
force-pushed
the
enh/noid/dav-object-headers
branch
from
3990426 to
82c0d19
Compare
tcitworld
approved these changes
Jul 18, 2021
Member
|
Is there an issue in server for |
Member
Author
I would think so, but I haven't had a look yet (and I don't know the server code well). Edit: For calendars, it is respected. When I don't send it, the calendar is not deleted, even though it is in the trash bin already. For calendar objects, this is different. If the object is in the trash bin, it is deleted on request, no matter if the |
Signed-off-by: Raimund Schlüßler <[email protected]> Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
enh/noid/dav-object-headers
branch
from
82c0d19 to
acfa605
Compare
ChristophWurst
approved these changes
Aug 13, 2021
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Sure :)
(sorry, still processing a long backlog of notifications after vacation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to set headers for requests on dav objects. Specifically needed to move objects without creating a trash bin entry before this is fixed in server. Unfortunately, the server does not seem to respect the header
X-NC-CalDAV-No-Trashbinfor dav objects.Related to nextcloud/tasks#1685 and nextcloud/calendar#3325