Skip to content

Conversation

@ArtificialOwl
Copy link
Member

No description provided.

Signed-off-by: Maxence Lange <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1118 (e7f3436) into stable23 (5548f16) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             stable23   #1118      +/-   ##
=============================================
- Coverage        0.69%   0.69%   -0.01%     
- Complexity       5777    5778       +1     
=============================================
  Files             292     292              
  Lines           19965   19966       +1     
=============================================
  Hits              139     139              
- Misses          19826   19827       +1     
Impacted Files Coverage Δ
lib/Listeners/DeprecatedListener.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5548f16...e7f3436. Read the comment docs.

@ArtificialOwl ArtificialOwl marked this pull request as ready for review August 2, 2022 10:53
@ArtificialOwl
Copy link
Member Author

/backport to stable24

@ArtificialOwl
Copy link
Member Author

/backport to stable23

@ArtificialOwl
Copy link
Member Author

/backport to stable22

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does a circle have no initiator?

@ArtificialOwl
Copy link
Member Author

excellent question, I think we are in a really specific use case with user not already existing locally, but being updated on ldap.
Because the method is only called when the the display name of the user is changed, it won't be a big issue if the display name is not updated if not available yet in database :]

@ArtificialOwl ArtificialOwl merged commit f46d691 into stable23 Aug 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/ignore-result-with-no-initiator branch August 2, 2022 11:20
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@ArtificialOwl
Copy link
Member Author

/backport to master

@backportbot-nextcloud
Copy link

The backport to master failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants