Skip to content

[stable29] Fix display name of new users #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArtificialOwl merged 1 commit into from
Oct 22, 2024
Merged

[stable29] Fix display name of new users #1687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Fix display name of new users 
Although the display name of users is updated in a circle when it is
changed in the user settings, the new display name was not shown if the
user was then added to a circle due to a missing update of the member
and, therefore, the cached name.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu @mejo-
danxuliu authored and mejo- committed Oct 22, 2024
commit 479952ec79d2f5ef36f5fec41df8ee374d2e5dba
5 changes: 4 additions & 1 deletion lib/Listeners/AccountUpdated.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

use Exception;
use OCA\Circles\Db\CircleRequest;
use OCA\Circles\Db\MemberRequest;
use OCA\Circles\FederatedItems\MemberDisplayName;
use OCA\Circles\Model\Federated\FederatedEvent;
use OCA\Circles\Model\Probes\CircleProbe;
Expand All @@ -50,7 +51,8 @@ public function __construct(
private CircleService $circleService,
private FederatedEventService $federatedEventService,
private FederatedUserService $federatedUserService,
private LoggerInterface $logger
private LoggerInterface $logger,
private MemberRequest $memberRequest
) {
}

Expand All @@ -67,6 +69,7 @@ public function handle(Event $event): void {
$user = $event->getUser();
$federatedUser = $this->federatedUserService->getLocalFederatedUser($user->getUID());

$this->memberRequest->updateDisplayName($federatedUser->getSingleId(), $user->getDisplayName());
$this->circleRequest->updateDisplayName($federatedUser->getSingleId(), $user->getDisplayName());
$this->federatedUserService->setCurrentUser($federatedUser);

Expand Down