Skip to content

Conversation

@ArtificialOwl
Copy link
Member

Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl
Copy link
Member Author

/backport to stable30

@ArtificialOwl
Copy link
Member Author

/backport to stable29

@ArtificialOwl
Copy link
Member Author

/backport to stable28

Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a minor improvement to add here.

@nfebe
Copy link
Contributor

nfebe commented Oct 31, 2024

Resolves : #1737

@nfebe nfebe force-pushed the fix/noid/jsonserialize-encode branch 2 times, most recently from 393ad12 to 10035f1 Compare October 31, 2024 22:21
@nfebe
Copy link
Contributor

nfebe commented Oct 31, 2024

Have a minor improvement to add here.

Discarded as getAttributes returns either an object or null, other type checks which is what I had in mind are unnecessary.

@ArtificialOwl ArtificialOwl merged commit d1cbe12 into master Oct 31, 2024
@ArtificialOwl ArtificialOwl deleted the fix/noid/jsonserialize-encode branch October 31, 2024 22:34
@artonge artonge mentioned this pull request Nov 4, 2024
5 tasks
@susnux susnux moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

3 participants