fix: propagate group name changes

[st3iny]

My attempt to fix #1828

Does not fully solve the linked issue.

Remaining problem: Existing members are not updated. Only the group circle.

[ArtificialOwl]

I am not sure I see the the purpose of this change. the name only stores groupid, not the display name

[sorbaugh]

@st3iny @ArtificialOwl can you provide each other a bit more context to move this PR forward, thank you very much 🙏

[st3iny]

I linked the issue in the PR description. The issue contains concrete steps to reproduce the problem.

My observations: Renaming a group does not trigger renaming the mapped group inside circles. Somehow, it seems that the group rename event is not listened to and handled.

[sorbaugh]

From the ticket:

Steps to reproduce

1. Create a user group group-test.
2. Add the user group to a circle.
3. Rename the user group to group-renamed.
4. Open the membership modal again.

Observe that the group is still listed with the former name group-test.

Expected behaviour

The new name should be used in Circles.

Actual behaviour

The initial user group name is used everywhere which is confusing.

Server configuration

Nextcloud version: master (as of today)

[provokateurin]

Changes look sane and renaming groups does work correctly with the changes checked out.

[provokateurin]

@st3iny cs-fixer is unhappy

[ArtificialOwl]

/backport to stable31

[ArtificialOwl]

/backport to stable30

[ArtificialOwl]

/backport to stable29

[ArtificialOwl]

/backport to stable28

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)