Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Feb 12, 2025

This prevent confusing users with emails containing link that lead to an error page.

This prevent confusing users with emails containing link that lead to an error page.

Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge added this to the Nextcloud 31 milestone Feb 12, 2025
@artonge artonge self-assigned this Feb 12, 2025
@Altahrim Altahrim mentioned this pull request Feb 12, 2025
4 tasks
@ArtificialOwl
Copy link
Member

I have no problem merging this, but might be nice to display a message somewhere that external members have no use if public share is disable

@artonge
Copy link
Contributor Author

artonge commented Feb 18, 2025

Cross posting from another issue:

Are "circles shares" simply "public share" in disguise?
Not sure what would be expected here, should we disable circles shares if public shares are disabled?

@ArtificialOwl
Copy link
Member

Circle shares are normal internal shares until you add a mail address as member to the Team. Then a public link is generated and sent by mail

we could disable adding external members (as mail address) to a Team, or displaying a notice that those people wont receive a mail because of the current setup

@artonge
Copy link
Contributor Author

artonge commented Feb 18, 2025

@marcoambrosini, @nfebe, what do you think about Maxence suggestion? It would indeed make sense to add a warning in the sharing sidebar when public shares are disabled.

@artonge artonge merged commit 120838f into master Feb 18, 2025
31 checks passed
@artonge artonge deleted the artonge/fix/dont_send_link_if_public_share_disabled branch February 18, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants