Speedup circles fetching #1913
Merged
Speedup circles fetching #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
juliusknorr
approved these changes
Mar 17, 2025
Member
|
please set There should be better way to implement this, but I am still fine |
Signed-off-by: Kostiantyn Miakshyn <[email protected]>
Koc
force-pushed
the
feature/speedup-collectives-list
branch
from
1a31bae to
a7f29f0
Compare
Contributor
Author
|
@ArtificialOwl I did requested changes. Can we merge it? |
mejo-
approved these changes
Apr 1, 2025
Member
|
/backport to stable31 |
Member
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our organization we have circles with thousands of people. This leads api for fetching collectives list extremely slow, up to 30s. This happens because we loading all members of the circle for
canLeavecheck. With suggested change we can reduce amount of loaded users.This PR is preparation for a fix. Actual fix in collectives repo.