Skip to content

[stable30] Speedup circles fetching #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Koc merged 1 commit into from
Apr 1, 2025
Merged

[stable30] Speedup circles fetching #1951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/Db/MemberRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,14 +197,18 @@ public function updateLevel(Member $member): void {
public function getMembers(
string $singleId,
?IFederatedUser $initiator = null,
?MemberProbe $probe = null
?MemberProbe $probe = null,
int $limit = 0,
): array {
if (is_null($probe)) {
$probe = new MemberProbe();
}

$qb = $this->getMemberSelectSql($initiator);
$qb->limitToCircleId($singleId);
if ($limit > 0) {
$qb->chunk(0, $limit);
}

$qb->setOptions(
[CoreQueryBuilder::MEMBER],
Expand Down
4 changes: 2 additions & 2 deletions lib/Model/Circle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,9 +430,9 @@ public function setMembers(array $members): self {
/**
* @return Member[]
*/
public function getMembers(): array {
public function getMembers(int $limit = 0): array {
if (!$this->hasMembers()) {
$this->getManager()->getMembers($this);
$this->getManager()->getMembers($this, $limit);
}

return $this->members;
Expand Down
4 changes: 2 additions & 2 deletions lib/Model/ModelManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ public function getConfigService(): ConfigService {
/**
* @param Circle $circle
*/
public function getMembers(Circle $circle): void {
public function getMembers(Circle $circle, int $limit = 0): void {
try {
$circle->setMembers($this->memberRequest->getMembers($circle->getSingleId()));
$circle->setMembers($this->memberRequest->getMembers($circle->getSingleId(), limit: $limit));
} catch (RequestBuilderException $e) {
// TODO: debug log
}
Expand Down
Loading