Skip to content

exception on non visible circle #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Aug 25, 2021
Merged

exception on non visible circle #803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/FederatedItems/CircleLeave.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
use OCA\Circles\AppInfo\Application;
use OCA\Circles\Db\CircleRequest;
use OCA\Circles\Db\MemberRequest;
use OCA\Circles\Exceptions\CircleNotFoundException;
use OCA\Circles\Exceptions\FederatedItemException;
use OCA\Circles\Exceptions\MemberNotFoundException;
use OCA\Circles\Exceptions\RequestBuilderException;
Expand Down Expand Up @@ -156,9 +157,12 @@ public function verify(FederatedEvent $event): void {
$initiator = new FederatedUser();
$initiator->importFromIFederatedUser($member);

$outcome = $this->circleRequest->getCircle($circle->getSingleId(), $initiator);

$event->setOutcome($this->serialize($outcome));
try {
$outcome = $this->circleRequest->getCircle($circle->getSingleId(), $initiator);
$event->setOutcome($this->serialize($outcome));
} catch (CircleNotFoundException $e) {
// if member have no visibility on the circle after leaving it, we don't fill outcome
}
}


Expand Down