-
Notifications
You must be signed in to change notification settings - Fork 56
filter allowed type of member #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable22 |
|
Hi the patch is great, but the error message displayed on the web interface should be more clear. Actually we have "Some members could not be added" but it would be great to have something like "Adding external users has been disabled by your administrator" or something like that. Actually the error message sound more like a bug to me. Thanks |
|
So, this is an issue for the Contacts App ! This is not really an issue, but more like a side effect that the Contacts App add 'groups' of new member, and not only one. So the error message is kept global as some new members from the request might have been accepted I would define that as a missing feature, adding a customized message might require a lot of work. Maybe try to open a feature request, someone from the community might be interested |
|
@artonge please review this one too. |
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, looks like my review stayed as "Pending" and was not published.
Signed-off-by: Maxence Lange <[email protected]>
debd747 to
583fc31
Compare
|
rebased, and fixed #820 (comment) |
|
/backport to stable23 |
No description provided.