Skip to content

Conversation

@ArtificialOwl
Copy link
Member

No description provided.

@ArtificialOwl
Copy link
Member Author

/backport to stable22

@menardorama
Copy link

Hi the patch is great, but the error message displayed on the web interface should be more clear.

Actually we have "Some members could not be added" but it would be great to have something like "Adding external users has been disabled by your administrator" or something like that.

Actually the error message sound more like a bug to me.

Thanks

@ArtificialOwl
Copy link
Member Author

@menardorama

So, this is an issue for the Contacts App !

This is not really an issue, but more like a side effect that the Contacts App add 'groups' of new member, and not only one. So the error message is kept global as some new members from the request might have been accepted

I would define that as a missing feature, adding a customized message might require a lot of work. Maybe try to open a feature request, someone from the community might be interested

@ArtificialOwl
Copy link
Member Author

@artonge please review this one too.

@solracsf solracsf requested a review from artonge December 6, 2021 13:05
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, looks like my review stayed as "Pending" and was not published.

@ArtificialOwl ArtificialOwl requested a review from mejo- December 13, 2021 10:05
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/filter-member-types branch from debd747 to 583fc31 Compare December 13, 2021 11:51
@ArtificialOwl
Copy link
Member Author

rebased, and fixed #820 (comment)

@ArtificialOwl ArtificialOwl merged commit 59c6658 into master Dec 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/filter-member-types branch December 13, 2021 12:48
@artonge
Copy link
Contributor

artonge commented Dec 13, 2021

/backport to stable23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants