Skip to content

Add OCI ci and make tests not silently failing #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlSchwan merged 6 commits into from
Mar 28, 2022
Merged

Add OCI ci and make tests not silently failing #900

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
718fb3d
Add OCI ci
CarlSchwan Jan 11, 2022
c1c41c7
Add debug output
CarlSchwan Jan 12, 2022
e403c36
Fix silently failing tests
CarlSchwan Jan 12, 2022
83ac8b0
Fix the Controller tests and disabled the api tests
CarlSchwan Mar 11, 2022
b520fcb
shorten aliases
ArtificialOwl Mar 15, 2022
583af2a
primaryKey on circles_membership
ArtificialOwl Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add debug output 
Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
@CarlSchwan
CarlSchwan committed Mar 28, 2022
commit c1c41c7a41705e86506a45086f221464f0286335
2 changes: 2 additions & 0 deletions lib/Db/CircleRequestBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ public function getItemFromRequest(CoreQueryBuilder $qb): Circle {
$circle = $qb->asItem(Circle::class);
} catch (RowNotFoundException $e) {
throw new CircleNotFoundException('Circle not found');
} catch (\Exception $e) {
throw new \Exception($qb->getSQL());
}

return $circle;
Expand Down