block/force circle types #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable23 |
mejo-
approved these changes
Feb 23, 2022
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Looks good to me. If ConfigService->verify() and CircleService->create() are the only two places where the circle type may be set or changed (or changes are verified), then it should be good to go 👍
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
force-pushed
the
enh/noid/force+block-circles-type
branch
from
4647a99 to
087da84
Compare
delete-merged-branch
bot
deleted the
enh/noid/force+block-circles-type
branch
This was referenced Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
block and enforce circle types:
Enforce 'VISIBLE' flag to every circles managed by your users:
Block 'FRIEND' flag to every circles managed by your users: