Skip to content

Lighter SQL requests and compat with Oracle #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ArtificialOwl merged 9 commits into from
Mar 11, 2022
Merged

Lighter SQL requests and compat with Oracle #950

ArtificialOwl merged 9 commits into from
Mar 11, 2022

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Mar 9, 2022

No description provided.

@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Mar 9, 2022

fix #901
fix #789

This is a huge PR, split in multiple commit:

  1. import of MSPT: the external tools lib is now fully copied within the app, using OCA\Circles\Tools as namespace.
  2. switch import to OCA\Circles\Tools: calls to MSPT have been changed to reflect the import of the tools lib.
  3. population stored as setting: the idea here is to remove the calculation of the population of Circles during the SELECT request. Instead, the population is stored as a Circle's Setting. The calculation will be added in another Pull Request, until then population will be displayed at 0.
  4. removing useless SELECT DISTINCT and GROUPBY.
  5. instance can be empty string: Oracle does not like $expr->eq() on empty string, switching to $expr->emptyString() when needed.

@ArtificialOwl
cs-fix
9ff76b3 
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl marked this pull request as ready for review March 9, 2022 11:39
@ArtificialOwl ArtificialOwl requested a review from mejo- March 9, 2022 11:39
@ArtificialOwl ArtificialOwl mentioned this pull request Mar 9, 2022
Merged
CarlSchwan
CarlSchwan approved these changes Mar 10, 2022
View reviewed changes
CarlSchwan and others added 3 commits March 11, 2022 11:25
@CarlSchwan
Use dependency injection
7c153fd 
Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan
Remove autoloading of 3rdparty libraries
b6297da 
Since the library is now integrated inside the circle app, we don't need
this anymore and it wont' work when composer install --no-dev was used.

Signed-off-by: Carl Schwan <[email protected]>
@ArtificialOwl
cs-fix
ec0cbc8 
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl merged commit 9644708 into master Mar 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/sql-group-by+oracle branch March 11, 2022 12:22
@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Mar 11, 2022

/backport to stable22

@ArtificialOwl
Copy link
Member Author

ArtificialOwl commented Mar 11, 2022

/backport to stable23

This was referenced Mar 11, 2022
Closed
Merged
ArtificialOwl added a commit that referenced this pull request Mar 13, 2022
@ArtificialOwl
Merge pull request #957 from nextcloud/backport/950/950-stable22
5fb67f8 
[stable22] backport of #950 - support oracle
This was referenced Jun 14, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@mejo- mejo- Awaiting requested review from mejo-

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArtificialOwl @CarlSchwan