adding options 'is:?' to search #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
force-pushed
the
enh/noid/advanced-search
branch
from
39392cb to
66bd48f
Compare
ArtificialOwl
force-pushed
the
enh/noid/advanced-search
branch
from
66bd48f to
6f291a4
Compare
CarlSchwan
approved these changes
Jun 12, 2022
lib/Search/UnifiedSearchProvider.php
Outdated
Comment on lines
+53
to
+58
|
|
||
| /** @var IL10N */ | ||
| private $l10n; | ||
|
|
||
| /** @var FederatedUserService */ | ||
| private $federatedUserService; | ||
|
|
||
| /** @var SearchService */ | ||
| private $searchService; | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| /** @var IL10N */ | |
| private $l10n; | |
| /** @var FederatedUserService */ | |
| private $federatedUserService; | |
| /** @var SearchService */ | |
| private $searchService; | |
| private IL10N $l10n; | |
| private FederatedUserService $federatedUserService; | |
| private SearchService $searchService; |
|
|
||
|
|
||
| /** | ||
| * return unique id of the provider |
Member
There was a problem hiding this comment.
Suggested change
| * return unique id of the provider | |
| * Get the unique id of the provider |
Comment on lines
56
to
+62
|
|
||
| /** @var IURLGenerator */ | ||
| private $urlGenerator; | ||
|
|
||
| /** @var CircleService */ | ||
| private $circleService; | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| /** @var IURLGenerator */ | |
| private $urlGenerator; | |
| /** @var CircleService */ | |
| private $circleService; | |
| private IURLGenerator $urlGenerator; | |
| private CircleService $circleService; |
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
===========================================
- Coverage 0.69% 0.69% -0.01%
- Complexity 5741 5787 +46
===========================================
Files 291 293 +2
Lines 19869 20007 +138
===========================================
Hits 139 139
- Misses 19730 19868 +138
Continue to review full report at Codecov.
|
ArtificialOwl
force-pushed
the
enh/noid/advanced-search
branch
2 times, most recently
from
d696cf4 to
cd7ab6d
Compare
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
force-pushed
the
enh/noid/advanced-search
branch
from
cd7ab6d to
876096e
Compare
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding options to the search bar to filter Circles:
is:member,is:moderator,is:owner,is:admin