fix PrimaryKey on circles_event #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
commented
Mar 11, 2022
|
|
||
| /** | ||
| * Class Version0023Date20211216113101 | ||
| * Class Version0024Date20220203123901 |
Member
Author
There was a problem hiding this comment.
keep an empty version of Version0023Date20211216113101
ArtificialOwl
commented
Mar 11, 2022
| ] | ||
| ); | ||
|
|
||
| $table->addUniqueIndex(['token', 'instance']); |
ArtificialOwl
force-pushed
the
fix/noid/refresh-primary-key-on-events
branch
from
00bf5d2 to
1d33c58
Compare
CarlSchwan
approved these changes
Mar 14, 2022
Comment on lines
+48
to
+54
|
|
||
| /** | ||
| * @param IDBConnection $connection | ||
| */ | ||
| public function __construct(IDBConnection $connection) { | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| /** | |
| * @param IDBConnection $connection | |
| */ | |
| public function __construct(IDBConnection $connection) { | |
| } |
Comment on lines
+43
to
+49
|
|
||
| /** | ||
| * @param IDBConnection $connection | ||
| */ | ||
| public function __construct(IDBConnection $connection) { | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| /** | |
| * @param IDBConnection $connection | |
| */ | |
| public function __construct(IDBConnection $connection) { | |
| } |
not used
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
force-pushed
the
fix/noid/refresh-primary-key-on-events
branch
from
1d33c58 to
beb0c8d
Compare
CarlSchwan
reviewed
Mar 14, 2022
Comment on lines
+72
to
+73
| 'length' => 127 | ||
| ] |
Member
There was a problem hiding this comment.
Suggested change
| 'length' => 127 | |
| ] | |
| 'length' => 127 | |
| ] |
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable23 |
delete-merged-branch
bot
deleted the
fix/noid/refresh-primary-key-on-events
branch
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.