Skip to content

Conversation

@dartcafe
Copy link
Contributor

@dartcafe dartcafe commented Oct 26, 2021

first try
fixes #6

Since v3 brings some breaking changes, I guess, it should be a major version update.
Also some remarks are recommended:

Signed-off-by: dartcafe <[email protected]>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Will give this a test soon :)

Signed-off-by: dartcafe <[email protected]>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Mail and works 🚀 :shipit:

Comment on lines -42 to -44
'list_syntax' => [
'syntax' => 'short',
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this intentional? It's this here, right:

list($a, $b) = …;
[$a, $b] = …;

I don't think we want to go back and allow the long one?

Copy link
Member

@ChristophWurst ChristophWurst Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't catch this but no, I would not go back. Could you send a PR to fix it? We can do a v1.0.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is this rule not supported anymore and "short" by default now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR in #8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it, because it is declared as default in 3.2.

From https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md

Changed default values of options

Rule Option Old value New value
list_syntax syntax 'long' 'short'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy, sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, that someone does a real review...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to php-cs-fixer 3

4 participants