fix(BackgroundJob): Don't make ExpirePageTrash choke without trash
#1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #968 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/backgroundjob_no_trash
branch
from
c0b2aae to
ea9fca5
Compare
juliusknorr
reviewed
Nov 14, 2023
Comment on lines
-19
to
+20
| ITimeFactory $time, | ||
| Expiration $expiration, | ||
| PageTrashBackend $trashBackend) { | ||
| ITimeFactory $time) { |
Member
There was a problem hiding this comment.
Starting with nextcloud 28 you could actually make them nullable, but good as it is as we cover more versions ;)
Member
Author
There was a problem hiding this comment.
Uh, that's great to learn. Not for now, but one day we'll drop support for everything below 28 😊
juliusknorr
reviewed
Nov 14, 2023
juliusknorr
approved these changes
Nov 14, 2023
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Small comment, otherwise fine 👍
The `files_versions` app cannot be enabled per user anyway. It's either there or not. And using `inferface_exists()` should be way faster than initializing `appManager`. Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/backgroundjob_no_trash
branch
from
ea9fca5 to
215626c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #968