feat: use search highlighting editor API from text #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
force-pushed
the
refactor/search-highlight
branch
2 times, most recently
from
b4d0c7d to
5ad5bd1
Compare
elzody
changed the title
mejo-
approved these changes
Aug 13, 2024
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Works nice, only a small comment.
And I pushed one commit that fixes the scrollIntoView() when in edit mode. I hope you don't mind 😬
elzody
force-pushed
the
refactor/search-highlight
branch
from
4b2c65e to
135601e
Compare
mejo-
force-pushed
the
refactor/search-highlight
branch
from
135601e to
dfda617
Compare
elzody
force-pushed
the
refactor/search-highlight
branch
from
dfda617 to
2aea268
Compare
mejo-
force-pushed
the
refactor/search-highlight
branch
from
2aea268 to
43ad7e2
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
refactor/search-highlight
branch
from
f5ed3e8 to
f856f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes tests for: #1381
📝 Summary
This PR changes to using the refactored API for search highlighting. Instead of using @nextcloud/event-bus, we use the proper API implemented on the editor itself for searching within the editor.
Related PR: nextcloud/text#6199
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)