fix(circles): Use probeCircles() instead of getCircles()
#1592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
fix/probe_circles
branch
2 times, most recently
from
1fa84fe to
bc00e16
Compare
mejo-
force-pushed
the
fix/probe_circles
branch
from
bc00e16 to
d4c584d
Compare
`probeCircles()` is lighter and more performant. We can only use `probeCircles()` on newer Nextcloud versions though: * Nextcloud 31+ * Nextcloud 30 starting with 30.0.3 * Nextcloud 29 starting with 29.0.10 * Nextcloud 28 starting with 28.0.13 Fixes: #498 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/probe_circles
branch
from
d4c584d to
39c9587
Compare
ArtificialOwl
approved these changes
Dec 4, 2024
juliusknorr
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probeCircles()is lighter and more performant.Fixes: #498
Requires nextcloud/circles#1758
Todo
probeCircles()conditional and use only with Nextcloud >= 30.0.3, 29.0.10, 28.0.13🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)