feat: Implement a custom notification message for mentions #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2025
Merged
marcoambrosini
approved these changes
Feb 27, 2025
jancborchardt
requested changes
Feb 27, 2025
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Small detail: In Collectives we never refer to a page as "Readme" so it would be good to use the page name. Meaning:
- If it's the Readme of a folder, use the folder name
- If it's the Readme of a Collective, just use only the Collective name and don't append the "- Readme" part
Is that possible @juliusknorr?
mejo-
force-pushed
the
feat/mention-notification
branch
3 times, most recently
from
12a2994 to
9568d6e
Compare
mejo-
approved these changes
May 13, 2025
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks @juliusknorr, works well! I pushed some minor changes (displaying "Landingpage" instead of "Readme"), a cypress test and some fixes to make psalm happy.
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
feat/mention-notification
branch
3 times, most recently
from
c7d99a6 to
6f3e680
Compare
Unpacking associative arrays requires PHP 8.1+ Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
feat/mention-notification
branch
from
6f3e680 to
09d7ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires nextcloud/text#6923
Fixes #1469
This makes sure that for mentions in collectives we have a proper notification message and redirect the user to the collective page instead of the file.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)