Skip to content

Bump psalm error level and fix issues spotted by psalm #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mejo- merged 26 commits into from
May 26, 2025
Merged

Bump psalm error level and fix issues spotted by psalm #1768

mejo- merged 26 commits into from
May 26, 2025

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented May 20, 2025 •
edited
Loading

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo- mejo- self-assigned this May 20, 2025
@mejo- mejo- requested a review from max-nextcloud as a code owner May 20, 2025 15:55
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team May 20, 2025
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Office team May 20, 2025
@mejo- mejo- requested a review from a team May 20, 2025 15:56
@mejo- mejo- force-pushed the feat/psalm_deprectations_error branch from 2e15d6d to 3f0c810 Compare May 20, 2025 15:59
max-nextcloud
max-nextcloud reviewed May 22, 2025
View reviewed changes
mejo- added 15 commits May 26, 2025 10:58
@mejo-
chore(psalm): Migrate spaces to tabs
3b7eac3 
Signed-off-by: Jonas <[email protected]>
@mejo-
test(psalm): Bump error level to 4
7f0f056 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(PageInfo): Allow null fullWidth
deed7a9 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(CollectiveStorage): Fix return type and add missing import
45d6559 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(ExpireManager): Remove dead logic
17b30e9 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(ExpireManager): Do not expire labeled versions
a526189 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(ExpireManager): Add missing return types
de924e2 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(ExpireManager): Remove accidentally removed condition
5111991 
The condition was added in bfae0d1, but seems like by accident.

Signed-off-by: Jonas <[email protected]>
@mejo-
fix(VersionsBackend): Fix type for CollectiveVersion argument
e66c649 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(CollectiveShare): Adjust return types and remove dead code
eaed2db 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(psalm): Update stubs for circles app
c4cac94 
Signed-off-by: Jonas <[email protected]>
@mejo-
chore(psalm): Migrate spaces to tabs
2bb4897 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(MountProvider): Remove nulls from returned array in getMountsForUser
1142ed6 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix: Don't call getUID() on null
d5582f8 
Signed-off-by: Jonas <[email protected]>
@mejo-
fix(PageController): always pass index to copy/move function
a9d01d5 
Signed-off-by: Jonas <[email protected]>
@mejo- mejo- force-pushed the feat/psalm_deprectations_error branch from 3f0c810 to d94658c Compare May 26, 2025 13:41
@mejo- mejo- changed the title feat(psalm): Treat deprecated code as error Bump psalm error level and fix issues spotted by psalm May 26, 2025
@mejo- mejo- force-pushed the feat/psalm_deprectations_error branch from d94658c to 32ca079 Compare May 26, 2025 13:46
@mejo- mejo- force-pushed the feat/psalm_deprectations_error branch 2 times, most recently from 1b7a20d to 534032a Compare May 26, 2025 13:55
@mejo- mejo- force-pushed the feat/psalm_deprectations_error branch from 534032a to 1703911 Compare May 26, 2025 14:02
@mejo- mejo- requested a review from max-nextcloud May 26, 2025 15:05
@mejo- mejo- merged commit 86322be into main May 26, 2025
54 of 55 checks passed
@mejo- mejo- deleted the feat/psalm_deprectations_error branch May 26, 2025 16:30
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grnd-alt grnd-alt grnd-alt approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@mejo- mejo-

Labels

3. to review tests

Projects

📝 Office team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mejo- @grnd-alt @max-nextcloud