Refactor: Move TextEditor handling in its own component #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
refactor/page_editor
branch
from
ef9c493 to
14298d5
Compare
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
mejo-
force-pushed
the
refactor/page_editor
branch
from
7e3d2f9 to
ebd21ee
Compare
juliusknorr
reviewed
Jan 25, 2023
juliusknorr
approved these changes
Jan 25, 2023
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Change looks good. I added two follow up requirements from reading the diff to the text pr checklist:
- Things that collectives triggers
- Save through syncService.save()
- focusEditor
Preparations for using the new editor API from Text, see nextcloud/text#3615 Signed-off-by: Jonas <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
refactor/page_editor
branch
from
02a695c to
226de5e
Compare
max-nextcloud
approved these changes
Jan 25, 2023
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Tested to confirm ui issue when pressing enter quickly after creating a new page is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparations for using the new editor API from Text, see nextcloud/text#3615
Signed-off-by: Jonas [email protected]