Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 28, 2023

Adapt to the rename of the internal scanner class for object storage. I kept the NoopScanner to not break compatibility with old releases.

This originates from nextcloud/server#37691 so it would be good to include it in the next bugfix release for 27 as well.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliusknorr juliusknorr requested review from blizzz and mejo- June 28, 2023 06:14
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Jun 28, 2023
@cypress
Copy link

cypress bot commented Jun 28, 2023

16 failed tests on run #838 ↗︎

16 56 0 0 Flakiness 0

Details:

fix: Switch to ObjectStoreScanner if NoopScanner is not available
Project: Collectives Commit: bf8ee85c7e
Status: Failed Duration: 22:39 💡
Started: Jun 28, 2023 6:21 AM Ended: Jun 28, 2023 6:44 AM
Failed  pages-links.spec.js • 14 failed tests

View Output Video

Test Artifacts
Page Link Handling > Link handling to collectives > Opens link with URL to page in this collective in same/new tab depending on view/edit mode Output Screenshots
Page Link Handling > Link handling to collectives > Opens link with absolute path to page in this collective in same/new tab depending on view/edit mode Output Screenshots
Page Link Handling > Link handling to collectives > Opens link with relative path to page in this collective with fileId in same/new tab depending on view/edit mode Output Screenshots
Page Link Handling > Link handling to collectives > Opens link with relative path to page in this collective with fileId and outdated path in same/new tab depending on view/edit mode Output Screenshots
Page Link Handling > Link handling to collectives > Opens link with relative path to page in this collective without fileId in same/new tab depending on view/edit mode Output Screenshots
Page Link Handling > Link handling to collectives > Opens link with relative path to markdown file in this collective without fileId in same/new tab depending on view/edit mode Output Screenshots
Page Link Handling > Link handling to collectives > Opens link with URL to page in other collective with fileId in same/new tab depending on view/edit mode Output Screenshots
Page Link Handling > Link handling to collectives > Opens link with absolute path to page in other collective without fileId in same/new tab depending on view/edit mode Output Screenshots
Page Link Handling > Link handling to Nextcloud > Opens link with URL to another Nextcloud app in new tab Output Screenshots
Page Link Handling > Link handling to Nextcloud > Opens link with absolute path to another Nextcloud app in new tab Output Screenshots
The first 10 failed tests are shown, see all 14 tests in Cypress Cloud.
Failed  pages.spec.js • 1 failed test

View Output Video

Test Artifacts
Page > Creating a page from template > New page has template content Output Screenshots
Failed  collective.spec.js • 1 failed test

View Output Video

Test Artifacts
Collective > reloading works > Shows the name in the disabled titleform Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo- mejo- merged commit 295bff7 into main Jun 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/object-store-scanner branch June 28, 2023 08:47
@mejo-
Copy link
Member

mejo- commented Jun 28, 2023

Thanks for the quick fix @juliushaertl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants