Skip to content

Migrate to Text editor API #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 40 commits into from
Nov 8, 2023
Merged

Migrate to Text editor API #936

Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
70dd334
refactor(Editor): rename TextEditor.vue, RichText.vue and Editor.vue
mejo- Sep 5, 2023
744c190
feat(Editor): Use Text API for editor
mejo- Sep 5, 2023
df84b6a
feat(Editor): Allow to toggle outline via editor API
mejo- Sep 6, 2023
40f08ae
feat(Editor): Set autofocus to false for editor via API
mejo- Sep 6, 2023
bba25d9
fix(TextEditor): Open empty pages in edit mode and focus editor
mejo- Sep 6, 2023
ae3c9f1
fix(TextEditor): fix adding/deleting/restoring images with editor API
mejo- Sep 7, 2023
7160fcb
fix(TextEditor): Pass shareToken to editor via API
mejo- Sep 7, 2023
919d3a1
fix(TextEditor): save document via editor API when editing is stopped
mejo- Sep 7, 2023
2332015
fix(TextEditor): Handle outline changes from within Text editor
mejo- Sep 7, 2023
e835a25
fix(TextEditor): Set sheet view according to full width setting
mejo- Oct 2, 2023
887e217
feat(TextEditor): Use MarkdownContentEditor via editor API for view mode
mejo- Oct 2, 2023
38def38
fix(TextEditor): show SkeletonLoading while loading page content
mejo- Oct 4, 2023
d082b79
fix(TextEditor): use our link handler for links in read mode
mejo- Oct 4, 2023
c424eea
test(cypress): Updated selectors for reader/editor
mejo- Oct 4, 2023
148ef8c
refactor(PageInfoBar): Remove dependency on store from component
mejo- Oct 10, 2023
5c9f6d3
feat(TextEditor): Pass PageInfoBar component as ReadonlyBar to reader
mejo- Oct 10, 2023
d1f3a1a
fix(TextEditor): Take care of new `newPageContent` flag
mejo- Oct 10, 2023
2612dfe
feat(editorApi): Check for editorApi version before using it
mejo- Oct 11, 2023
fddf9d7
chore(TextEditor): Remove obsolete scroll position handling
mejo- Oct 11, 2023
8029fc2
fix(TextEditor): Pass shareToken and filePath to MarkdownContentEditor
mejo- Oct 11, 2023
2494b54
fix(cypress): Adjust and simplify selectors for editor/reader
mejo- Oct 11, 2023
70922a1
refactor(TextEditor): move setupReader and setupEditor into mixin
mejo- Oct 31, 2023
2598d24
refactor(editorApi): Move `useEditorApi` getter to vuex store
mejo- Oct 31, 2023
37ec9e4
fix(TextEditor): Set `full-width-view`/`sheet-view` classes
mejo- Oct 31, 2023
806f2b5
feat(editorApi): Use editor API for version view
mejo- Oct 31, 2023
a0bbb85
fix(print): Add selectors for new editor/reader to print adjustments
mejo- Nov 1, 2023
bca8938
feat(print): Migrate PagePrint to editor API
mejo- Nov 1, 2023
d0d58b3
feat(print): Improve logic to wait for loading images
mejo- Nov 1, 2023
851b280
fix(version): Don't show lastuser info in pageinfobar in version view
mejo- Nov 1, 2023
cfd6af8
fix(TextEditor): Set pageContent for reader when loaded
mejo- Nov 1, 2023
61b59b3
fix(editor): Fix outline visibility
mejo- Nov 1, 2023
e865534
refactor(css): Simplify sheet/fullwidth view CSS selectors
mejo- Nov 6, 2023
dea4324
test(cypress): Remove ridiculously long timeout when waiting for editor
mejo- Nov 6, 2023
79b5860
test(cypress): More specific selector for attachment input field
mejo- Nov 6, 2023
e752a47
refactor(TextEditor): Further simlify reader/editor logic
mejo- Nov 7, 2023
138eddd
test(cypress): Fix page trash tests
mejo- Nov 7, 2023
77647c2
test(cypress): Wait for editor/reader being visible in page link tests
mejo- Nov 7, 2023
254a1ac
fix(editor): debounce updating reader content from editor content
mejo- Nov 7, 2023
4db8525
chore: Remove obsolete `.files_from_text` file
mejo- Nov 7, 2023
81297c1
fix(deps): Update @nextcloud/files and @nextcloud/dialogs
mejo- Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(TextEditor): Pass shareToken and filePath to MarkdownContentEditor 
Required for attachments to work in reader.

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Nov 8, 2023
commit 8029fc2c72a4fe42d554ff5c82a98ec7a951a714
2 changes: 2 additions & 0 deletions src/components/Page/TextEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,9 @@ export default {
this.reader = await window.OCA.Text.createEditor({
el: this.$refs.reader,
content: this.pageContent,
filePath: `/${this.currentPageFilePath}`,
readOnly: true,
shareToken: this.shareTokenParam || null,
readonlyBar: {
component: PageInfoBar,
props: {
Expand Down