Save UID and display name for managers of the org chart #2962
Conversation
Codecov ReportBase: 31.21% // Head: 67.96% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2962 +/- ##
=============================================
+ Coverage 31.21% 67.96% +36.74%
Complexity 253 253
=============================================
Files 109 23 -86
Lines 1858 721 -1137
Branches 218 0 -218
=============================================
- Hits 580 490 -90
+ Misses 1163 231 -932
+ Partials 115 0 -115 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Seems to do the trick now |
ChristophWurst
added
3. to review
| // TODO: this only *shows* the display name but doesn't assign the missing UID | ||
| const displayName = this.property.getFirstValue() | ||
| const other = this.otherContacts(this.contact).filter(contact => contact.displayName === displayName) | ||
| return other?.key |
There was a problem hiding this comment.
| return other?.key | |
| return other.key |
The variable other is always defined because Array.filter in the line above always returns an array.
There was a problem hiding this comment.
This actually shows a problem. I meant to use .find instead of .filter. Then the result is undefind|object :)
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/org-chart-save-uid-and-display-name
branch
from
c79e597 to
240ee34
Compare
ChristophWurst
added
4. to release
Follow-up to #2954
Discussed in #2726 (comment)
Previously assigned managers will show a broken link because we wrongly stored the UID as display name. Those contacts need to be fixed but it only affects dev and pre-production instances.