enh(addressbooks): add show/hide option for system and shared addressbooks

src/components/AppNavigation/Settings/SettingsAddressbook.vue

@@ -67,6 +67,21 @@
 					{{ t('contacts', 'Download') }}
 				</ActionLink>
 
+				<template v-if="addressbook.writeProps">
+					<!-- enable/disable addressbook -->
+					<ActionCheckbox v-if="!toggleEnabledLoading"
+						:checked="enabled"
+						@change.stop.prevent="toggleAddressbookEnabled">
+						{{ t('contacts', 'Show') }}
+					</ActionCheckbox>
+					<ActionButton v-else>
+						<template #icon>
+							<IconLoading :size="20" />
+						</template>
+						{{ t('contacts', 'Show') }}
+					</ActionButton>
+				</template>
+
 				<template v-if="!addressbook.readOnly">
 					<!-- rename addressbook -->
 					<ActionButton v-if="!editingName"
@@ -86,19 +101,6 @@
 							<IconRename :size="20" />
 						</template>
 					</ActionInput>
-
-					<!-- enable/disable addressbook -->
-					<ActionCheckbox v-if="!toggleEnabledLoading"
-						:checked="enabled"
-						@change.stop.prevent="toggleAddressbookEnabled">
-						{{ t('contacts', 'Enabled') }}
-					</ActionCheckbox>
-					<ActionButton v-else>
-						<template #icon>
-							<IconLoading :size="20" />
-						</template>
-						{{ t('contacts', 'Enabled') }}
-					</ActionButton>
 				</template>
 
 				<!-- delete addressbook -->

src/store/addressbooks.js

@@ -61,6 +61,7 @@ export function mapDavCollectionToAddressbook(addressbook) {
 		enabled: addressbook.enabled !== false,
 		owner: addressbook.owner,
 		readOnly: addressbook.readOnly === true,
+		writeProps: addressbook.currentUserPrivilegeSet.includes('{DAV:}write-properties') === true,
 		url: addressbook.url,
 		dav: addressbook,
 		shares: addressbook.shares
@@ -318,10 +319,17 @@ const actions = {
 			.update()
 			.then((response) => {
 				context.commit('toggleAddressbookEnabled', addressbook)
-				if (addressbook.enabled && Object.values(addressbook.contacts).length === 0) {
-					context.dispatch('getContactsFromAddressBook', { addressbook })
+				if (addressbook.enabled) {
+					// Add contacts from the just enabled address book to the contacts store
+					Object.values(addressbook.contacts).forEach((contact) => {
+						context.commit('addContact', contact)
+					})
+				} else {
+					// Remove contacts from the just disabled address book from the contacts store
+					Object.values(addressbook.contacts).forEach((contact) => {
+						context.commit('deleteContact', contact)
+					})
 				}
-
 			})
 			.catch((error) => { throw error })
 	},
@@ -386,9 +394,13 @@ const actions = {
 				}
 
 				context.commit('appendContactsToAddressbook', { addressbook, contacts })
-				context.commit('appendContacts', contacts)
 				context.commit('extractGroupsFromContacts', contacts)
-				context.commit('sortContacts')
+
+				// don't add contacts from disabled address book to contacts store
+				if (addressbook.enabled) {
+					context.commit('appendContacts', contacts)
+					context.commit('sortContacts')
+				}
 				return contacts
 			})
 			.catch((error) => {

src/views/Contacts.vue

@@ -347,8 +347,8 @@ export default {
 		 */
 		fetchContacts() {
 			// wait for all addressbooks to have fetch their contacts
+			// don't filter disabled at this point, because sum of contacts per address book is shown
 			Promise.all(this.addressbooks
-				.filter(addressbook => addressbook.enabled)
 				.map(addressbook => {
 					return this.$store.dispatch('getContactsFromAddressBook', { addressbook })
 				})