Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

Check if has photo DAV property is set to true before trying to download the photo, to stop 404 errors.

Before:
image

After:
image

@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 11.61%. Comparing base (b91012f) to head (f33c353).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/models/contact.js 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #4249       +/-   ##
=============================================
- Coverage     66.20%   11.61%   -54.59%     
  Complexity      262      262               
=============================================
  Files            25      117       +92     
  Lines           787     5441     +4654     
  Branches          0     1180     +1180     
=============================================
+ Hits            521      632      +111     
- Misses          266     4687     +4421     
- Partials          0      122      +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable6.1

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable6.0

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable5.5

@SebastianKrupinski SebastianKrupinski merged commit f6e225f into main Dec 13, 2024
32 of 34 checks passed
@SebastianKrupinski SebastianKrupinski deleted the fix/issue-3021-check-if-photo-exists branch December 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Development

Successfully merging this pull request may close these issues.

3 participants